CASL-1067 tags query enhancement #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Signed-off-by: Jakub Amanowicz <[email protected]>
Marcin-Here
reviewed
Sep 16, 2025
| // for tags without values we can utilize top-level-key based '?&' operand | ||
| // https://www.postgresql.org/docs/current/functions-json.html#FUNCTIONS-JSONB-OP-TABLE | ||
| resolveTagNamesArrayOperation( | ||
| jsonbOperator = "jsonb_exists_all", // equivalent of '?&' |
Contributor
There was a problem hiding this comment.
I think if we will get empty list (is it possible?) any will return false but all will return true. Is it behavior we want?
Contributor
Author
There was a problem hiding this comment.
No need to worry here :)
I think if we will get empty list (is it possible?)
It is not. See the function that guards the entrance to this call
private fun containsOnlyTagExists(container: ListProxy<ITagQuery>): Boolean =
container.all { it is TagExists }
this predicate won't hold on empty list.
Marcin-Here
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.