Skip to content

DS-1208: Support setName for user inputs and add JobInternalDelegateStep for delegating steps within same job#1508

Merged
roegi merged 65 commits intomasterfrom
userInputSets
Apr 15, 2025
Merged

DS-1208: Support setName for user inputs and add JobInternalDelegateStep for delegating steps within same job#1508
roegi merged 65 commits intomasterfrom
userInputSets

Conversation

@mujammil10
Copy link
Copy Markdown
Contributor

No description provided.

mchrza and others added 30 commits February 27, 2025 16:26
Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
- Add logging to TaskedSpaceBasedStep#prepare()

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Also ignore "_SUCCESS" files.

Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
…er error

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
# Conflicts:
#	xyz-jobs/xyz-job-service/src/main/java/com/here/xyz/jobs/steps/JobCompiler.java
# Conflicts:
#	xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/impl/transport/TaskedSpaceBasedStep.java
# Conflicts:
#	xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/impl/transport/TaskedSpaceBasedStep.java
Signed-off-by: Ansari, Mujammil <mujammil.ansari@here.com>
Signed-off-by: Maximilian Chrzan <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
…ortSpaceToFiles step

- Add flag to ImportFilesToSpace to allow re-using metadata from input files
- Skip step execution for ExportSpaceToFiles when passthrough flag is enabled and return inputs as outputs

Signed-off-by: Ansari, Mujammil <mujammil.ansari@here.com>
This change enables the user to define multiple input sets that are distinguishable by names. Depending on the expectations of the job, the different input sets can be assigned to be used for different purposes by the job compiler.

The change is backwards compatible. If the user provides an "unnamed" input-set it has the default name "inputs".

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…the job payload

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…ly with new named user input-sets

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>

# Conflicts:
#	xyz-jobs/xyz-job-steps/src/main/java/com/here/xyz/jobs/steps/impl/transport/ExportSpaceToFiles.java
- These methods use JsonObject for requests and responses.
- Also fix Future mapping in JobApi#applyInputReferences

Signed-off-by: Ansari, Mujammil <mujammil.ansari@here.com>
roegi and others added 24 commits April 7, 2025 15:57
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
- Also remove INTERNAL_STATISTICS outputs

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…rs when mocking the execution of a step within the same job while re-using the outputs

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
… step

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
- Adjust input set after fusion to include correct step ID
- Skip DelegateStep(s) during step validation

Signed-off-by: Ansari, Mujammil <mujammil.ansari@here.com>
- Push down special implementations of DelegateStep#setOuputSets() & new JobInternalDelegateStep related constructor
- Add internal helper method Job#nonFinalSteps() to filter out steps with final states from the stepStream
- Remove obsolete method StepGraph#stepStream(boolean) from the generic StepGraph class

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…et was not found on the delegator that was present in the delegate - Flipped the way of iteration so that now only outputSets will be copied / referenced that are present at the compiled / new / delegator step

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…d through the job configuration.

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…rting the job

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…fied inline

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
… Service

Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
…step

Signed-off-by: Ansari, Mujammil <mujammil.ansari@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
@mujammil10 mujammil10 requested a review from a team as a code owner April 15, 2025 08:55
roegi added 2 commits April 15, 2025 13:35
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
Signed-off-by: Benjamin Rögner <benjamin.roegner@here.com>
@roegi roegi merged commit a2aaf1e into master Apr 15, 2025
1 of 3 checks passed
@roegi roegi deleted the userInputSets branch April 15, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants