Conversation
Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
Signed-off-by: mchrza <maximilian.chrzan@here.com>
| .recover(t -> { | ||
| if(t instanceof HttpException e && e.status == HttpResponseStatus.GONE) { | ||
| logger.warn(getMarker(context), e.getMessage()); | ||
| job.getStatus() |
There was a problem hiding this comment.
Shouldn't we call job.cancel() here or inside the #abortIfClientGone ?
There was a problem hiding this comment.
In this case we cant provide a proper errorMessage.
There was a problem hiding this comment.
We will not be able to provide the error message anyway, coz the client closed the connection already.
Also, if we do not cancel the job, it will still be executing in the step function.
roegi
left a comment
roegi
left a comment
There was a problem hiding this comment.
This has to wait to go in until #1554 was merged.
Also then we have to change this a bit to use a "CancellableFuture" to be used during the creation of the job. That would enable us to cancel the job while its creation / compilation / validation of the job is still ongoing. Now we would simply prevent to start the execution, but service resources would be blocked anyways.
3 participants
No description provided.