Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #53: Bazel may put an empty declared output directory in the input root. Mirroring it into the writable stage makes untouched output collection work, but its immutable lower-tree entry still prevents an action from removing and recreating that directory. This breaks tools such as rules_foreign_cc.
Rewrite the mounted input-root descriptors to omit only empty declared output directories after preparing their stage directories. Preserve unrelated inputs and nonempty directories, and continue collecting declared outputs from the writable stage.
The added unit case checks nested directory rewriting and preservation of ordinary inputs. A native action that removes and recreates its declared output directory passed in the combined integration run.
Validation was performed with these fixes combined in a Linux KVM integration workspace, using actiond for execution and caching. The native unit suite, filesystem probes, and a large mixed-language Bazel workload passed. These draft changes have not been validated with
tools/e2e.sh vmon macOS.