Repository navigation
docs: document additional library macros with regression coverage - #108
Merged
Merged
Conversation
longlho
enabled auto-merge (squash)
September 27, 2026 03:26
longlho
disabled auto-merge
September 28, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: second TypeScript library macro appears unrecognized; consumers retain dependencies with
# keep. Existingalias_kindsetup lacked documented example and regression coverage.Gazelle canonicalizes aliases before
Imports. Withmap_kind ts_library app_ts_library, usealias_kind node_ts_library app_ts_library: existing macro stays, new libraries use default. Scopedmap_kindalso works when subtree should generate second macro.Document both. Add fixtures proving inferred dependencies and preserved macros, including ignored producer with literal generated source. No plugin behavior change.
Validation: unit and generation suites pass at
701dd6ewith resolved Gazelle 0.51.3. Second alias run unchanged; removing alias loses ignored-producer dependency. gazelle_ts 0.6.5 not separately tested.