Skip to content

fix: use compatible prost/tonic crate versions for default toolchain#105

Closed
kormide wants to merge 1 commit into
hermeticbuild:mainfrom
kormide:prost-versions
Closed

fix: use compatible prost/tonic crate versions for default toolchain#105
kormide wants to merge 1 commit into
hermeticbuild:mainfrom
kormide:prost-versions

Conversation

@kormide
Copy link
Copy Markdown
Contributor

@kormide kormide commented Apr 27, 2026

The tonic/prost versions used in the default toolchain don't work together, causing errors like:

error[E0599]: no associated item named `GRPC_STATUS` found for struct `Status` in the current scope
   --> bazel-out/k8-fastbuild/bin/external/googleapis+/google/devtools/build/v1/build_proto.lib.rs:932:48
    |
932 | ...                   tonic::Status::GRPC_STATUS,
    |                                      ^^^^^^^^^^^ associated item not found in `Status`

People can define their own rust_prost_toolchain, but the default set ought to still work.

Tested via a patch to rules_rs from a consuming module that calls rust_prost_library.

@kormide
Copy link
Copy Markdown
Contributor Author

kormide commented Apr 27, 2026

fyi @dzbarsky

@dzbarsky
Copy link
Copy Markdown
Member

@kormide can you check if #59 works? I didn't succeed in getting my existing guinea pigs to verify it :)

@kormide
Copy link
Copy Markdown
Contributor Author

kormide commented Apr 27, 2026

@kormide can you check if #59 works? I didn't succeed in getting my existing guinea pigs to verify it :)

Oh I didn't see your PR. Tested with a local_path_override and yes, it works!

@kormide kormide closed this Apr 27, 2026
@dzbarsky
Copy link
Copy Markdown
Member

Cool! I merged that and will cut new releases tomorrow after I get the bot account sorted out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants