Rejigger git repo support#113
Merged
Merged
Conversation
dzbarsky
force-pushed
the
zbarsjy/git-repos
branch
from
dbb6050 to
e5c96be
Compare
dzbarsky
force-pushed
the
zbarsjy/git-repos
branch
from
e5c96be to
d06b904
Compare
ArchangelX360
approved these changes
May 1, 2026
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
May 5, 2026
hermeticbuild/rules_rs#113 GitOrigin-RevId: 437703a30428bce5f49761d9d1a743e8bc1e5052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing way git crates are handles is a bit hacky - we do a deduped git clone for the external repo and then a per-crate
git worktree addand symlink things around. We can instead do a single clone and add per-crate BUILD file overlaid onto it (which are still generated by per-crate helper repos). This avoids all usage of worktrees and symlinks, which incidentally should improve both Windows and R2C2 support.