[toolchains] Add opt-in nightly rustc-dev toolchains#122
Open
andyscott wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustc-devsupport for generated nightly Rust toolchainsMotivation
Generated
rules_rstoolchains currently cannot support nightly crates that depend onrustc_private, because those crates need therustc-devcomponent in the compiler sysroot.This adds that capability as an explicit nightly-only opt-in so downstream users can support
rustc_privateworkloads without making ordinary toolchains larger or changing default selection behavior.Details
include_rustc_dev = Trueto the toolchain module extensionrustc-devseparately from ordinaryrustcrustc_with_devsysroots only for dev-enabled toolchains*_with_devtoolchains behind@rules_rs//rs/toolchains/rustc_dev:enabled.rlibinputsValidation
bazel build //rs/toolchains:module_extension //rs/private:rustc_dev_repository //rs/private:rustc_with_dev_repository