Repository navigation
feat: support cpp_link execution group for C/C++ linking - #695
Merged
Merged
Conversation
cerisier
changed the title
aherrmann
approved these changes
Nov 5, 2026
aherrmann
enabled auto-merge (squash)
November 5, 2026 12:22
cerisier
disabled auto-merge
November 5, 2026 12:22
Member
Author
|
@aherrmann I disabled auto-merge because I may change on detail about bundling the zig toolchain and the c++ toolchain together for cpp_link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constraining the Zig SDK to local execution currently leaves the final
cc_common.linkaction free to run remotely. This lets projects keep Zig compilation and final linking on compatible local execution platforms while native dependencies remain eligible for remote execution.The final link uses Bazel's
cpp_linkexecution group and its matching C/C++ toolchain, so it also accepts group-specific execution constraints and properties. C preprocessing and other linking helpers retain their existing execution selection.