feat(ci): add PR readiness check workflow#1539
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Add a GitHub Actions workflow that automatically checks PRs for common issues: - Missing DCO sign-off - Empty commit messages - Missing commit description - Merge commits The workflow uses pull_request_target to comment on fork PRs without checking out or executing PR code. It posts a single comment that updates on each push. Closes hermetoproject#1521 Signed-off-by: Priyanshu Kumar <connect.priyanshu8271@gmail.com>
2d4ac80 to
ec55107
Compare
|
Closing ? |
The idea is still sound - provide early feedback on new PRs on fundamentals. Review agents running in the repo context (i.e. installed on the repo as a GH app or in a runner) only see the overall changes against the merge base. That said, I'm not particularly pleased we'd need to maintain a JS script in a new GH workflow (which truth to be told was the expected outcome given the options we have). I also considered what if we formulated this as some preflight-check agent skill locally - well, that just invites anyone to open a PR with a malicious intent to prompt inject local systems hoping folks would run the preflight-check blindly on any new PR. |
|
Okay 😄 But I think the idea of having a script for checking commit message body is wild. Hopefully, it won't discourage some human contributors. |
It is. This surely is effort that is providing marginal improvement, we've known that since the beginning. There are various factors on why that is and why we're limited. I'm okay if we abandon this effort. It was needed when we got the wave of AI slop a few months back but the situation has stabilized for now. |
|
Thanks for the discussion! I understand that the original problem has been resolved, so I'm happy to close this PR. |
Add a GitHub Actions workflow that automatically checks PRs for common issues and posts an actionable comment.
The workflow uses
pull_request_targetto comment on fork PRs without checking out or executing PR code. It posts a single comment that updates on each push. It skips DCO/description checks on merge commits (fix is to remove them).Groups issues by type to keep comments clean
Demo
Tested on my fork with different scenarios:
Note:
In addition to the checks discussed in #1521 , I also added a check for missing commit description body, since all merged PRs in the repo follow this convention. Happy to remove if preferred.
Closes #1521

