enhancement(python): Moved pip backend and it's unit tests to a /python directory#1642
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by moving the pip package manager under a new python namespace directory (hermeto/core/package_managers/python/pip). All corresponding imports and unit tests have been updated to reflect this new path. I have no feedback to provide as the changes are clean and consistent.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
04fef11 to
9ca18db
Compare
eskultety
left a comment
There was a problem hiding this comment.
One "mentoring" comment left as an improvement item ;). ACK to the change.
9ca18db to
1ab99f9
Compare
tnevrlka
left a comment
There was a problem hiding this comment.
Code changes LGTM, few style notes that I would like to see addressed before merging:
- Consider using the 50/72 rule -- try to fit the title under 50 chars and keep lines in a body under 72 chars, then wrap
- it's -> its
- Use imperative, e.g. Moved -> Move
While I acknowledge ^this to be the official recommendation (even by the git book itself?) even I don't follow the 50c rule on the subject line for 2 reasons:
That said, even 80c is nowadays deemed restrictive, but that's because many people fancy an ultrawide screen and working in an IDE. For those who still rock terminal setup in 24" fullHD screens 80-100c is still quite vital :), my 2 cents. |
Create a /python directory for pip backend and unit tests. Closes hermetoproject#1548 Signed-off-by: Mohamed Bouchtout <mbouchto@redhat.com>
1ab99f9 to
da77a07
Compare
resolves #1548
Summery
Created a /python directory for the
pipbackend andpipunit tests as requested in this issue, similar to what was done with the javascript package managers. Updated import paths to match the relocation.Details
pipbackend to a /python directorypipunit tests to a /python directory to match the backend structureuv)