annotate(hypercall/lseek): make sure missing constants cause compile-time error

[fogti]

Related: #1145 (comment)

In the Uhyve V2 Interface PR, the problem popped up that missing re-exports of SEEK_* constants only show up as warnings, and this gets fixed by this PR.

[mkroening]

Will this not error in CI anyway? Or is this about local development somehow? 🤔

[fogti]

It currently only produces a warning. Feel free to try.

[mkroening]

It produces a warning locally, sure. That decision was intentional to not hinder local development by erroring on every warning. But in CI it should already be an error:

uhyve/.github/workflows/ci.yml

Line 123 in f9de15f

run: cargo clippy --all-targets ${{ matrix.flags }} -- -D warnings

[fogti]

The problem is that this tiny piece of code completely breaks on missing constants and relying on CI for that feels like a bad idea, as it runs a bit too late (i.e. causes unnecessary CI runs, which waste time and resources).

[mkroening]

Okay so, yes, this is about local development. That answers my question. :D

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.28%. Comparing base (f9de15f) to head (3f6898b).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1170      +/-   ##
==========================================
- Coverage   76.61%   76.28%   -0.34%     
==========================================
  Files          28       28              
  Lines        3605     3605              
==========================================
- Hits         2762     2750      -12     
- Misses        843      855      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[fogti]

CI failure is unrelated (timeout).

[jounathaen]

Thx!