Repository navigation
fix(hypercall): bound read buffer to VM memory - #1500
Merged
Merged
Conversation
fogti
reviewed
Oct 5, 2026
fogti
reviewed
Oct 5, 2026
read resolved the guest buffer with host_address + from_raw_parts_mut, so a guest-controlled buf/len could fall outside the guest mapping and read or write host memory. Use slice_at_mut, as write/getdents/serialwrite already do, returning -EFAULT when the buffer is not within guest memory. Signed-off-by: Abhinav Madake <abhinavmadake@gmail.com>
Contributor
Author
|
thanks, done |
Abhinavmadake
force-pushed
the
read-bound-guest-buffer
branch
from
October 5, 2026 19:42
f619c00 to
22172d5
Compare
fogti
approved these changes
Oct 5, 2026
jounathaen
enabled auto-merge
October 5, 2026 21:11
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 79.69% 79.93% +0.23%
==========================================
Files 41 41
Lines 5640 5682 +42
==========================================
+ Hits 4495 4542 +47
+ Misses 1145 1140 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readresolved the guest buffer withhost_address+from_raw_parts_mut, so a guest-controlledbuf/lencould point outside the guest mapping.write,getdentsandserialwritealready bound their buffers withslice_at/slice_at_mut; this makesreadconsistent.slice_at_mutso an out-of-range or oversized buffer returns-EFAULTinstead of reading or writing past VM memoryFixes #1499