Protobuf Support for .NET Socket - #47
Open
lugehorsam wants to merge 33 commits into
Open
Conversation
added 30 commits
December 10, 2020 16:30
Closed
added 2 commits
February 9, 2021 12:53
…g all datamember attributes
|
Luke Gehorsam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
lugehorsam
commented
Oct 6, 2021
| /// A Protobuf-Net serializable class corresponding to the well-known | ||
| /// google.protobuf.BoolValue type. | ||
| /// | ||
| /// Keep in mind that grpc-gateway will automatically deserialize a vool into a BoolValue; |
lugehorsam
commented
Oct 6, 2021
| return dataMemberAttribute.Name; | ||
| } | ||
| } | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds protobuf support to the .NET socket via annotations from protobuf-net.
It also moves the concrete socket models to
Nakama.Socket.Internal. These are no longer strictlyinternalbecause theNakama.Protobuf.dll needs access to them.The primary rationale behind using protobuf-net was its annotations feature. This allows us to not need to write glue code between the generated protobuf types and our interfaces.
The plan for Unity support would be to ship our protobuf .dll inside the same asset and simply document that
using Nakama.Protobufwill pull in the .dll. Otherwise the .dll will not be included in the build output.Note there is some duplication between the protobuf and text adapters w/r/t the socket lifecycle methods:
ConnectCloseSendandReceiveLoop. I debated merging them into some shared object but didn't think it was worth it.TODO
Socket.Internal: https://docs.microsoft.com/en-us/dotnet/standard/assembly/friend