Provide AWS Gamelift PlacementId#7
Open
kedigby wants to merge 4 commits into
Open
Conversation
… Id. Add placement Id check during creation, check if supplied else generate new new using the handler
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for providing a PlacementId to AWS GameLift game session placement requests to ensure placement requests only happen once. The implementation provides two approaches: accepting a PlacementId through metadata in the Create method, and exposing methods to generate placement IDs.
Key changes:
- Added PlacementIdKey constant and metadata handling in Create method
- Exposed public GeneratePlacementId method and GetPlacementId RPC endpoint
- Fixed a bug in playerLatencies slice initialization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
sesposito
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would like to provide PlacementId, so that gamesession placement request only happens once.
Solution 1
Add RPC to GameLiftFleetManager, which calls GenerateCallbackId.
Our implementation calls RPC prior to
Createand passes through in themetadata, if the PlacementId is not in themetadatathen theGenerateCallbackId()method is used to create PlacementIdSolution 2
Expose public method
GeneratePlacementId, which is called in our implementation prior toCreateand passes through in themetadataChanges
GeneratePlacementIdGetPlacementId