Skip to content

Provide AWS Gamelift PlacementId#7

Open
kedigby wants to merge 4 commits into
heroiclabs:masterfrom
kedigby:feature/GetPlacementIdFunc
Open

Provide AWS Gamelift PlacementId#7
kedigby wants to merge 4 commits into
heroiclabs:masterfrom
kedigby:feature/GetPlacementIdFunc

Conversation

@kedigby
Copy link
Copy Markdown

@kedigby kedigby commented Oct 7, 2025

Would like to provide PlacementId, so that gamesession placement request only happens once.

Solution 1

Add RPC to GameLiftFleetManager, which calls GenerateCallbackId.

Our implementation calls RPC prior to Create and passes through in the metadata, if the PlacementId is not in the metadata then the GenerateCallbackId() method is used to create PlacementId

Solution 2

Expose public method GeneratePlacementId, which is called in our implementation prior to Create and passes through in the metadata

Changes

  • Expose public method GeneratePlacementId
  • Create RPC GetPlacementId

danielmannixcw and others added 2 commits October 6, 2025 16:37
… Id. Add placement Id check during creation, check if supplied else generate new new using the handler
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 7, 2025

CLA assistant check
All committers have signed the CLA.

@novabyte novabyte requested review from Copilot and sesposito October 7, 2025 13:31
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for providing a PlacementId to AWS GameLift game session placement requests to ensure placement requests only happen once. The implementation provides two approaches: accepting a PlacementId through metadata in the Create method, and exposing methods to generate placement IDs.

Key changes:

  • Added PlacementIdKey constant and metadata handling in Create method
  • Exposed public GeneratePlacementId method and GetPlacementId RPC endpoint
  • Fixed a bug in playerLatencies slice initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread fleetmanager/gamelift_fleet_manager.go Outdated
Comment thread fleetmanager/gamelift_fleet_manager.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants