Update Node.js CNB to v5 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v5, the following provides are no longer used: - node_build_scripts This is replaced by the `heroku/nodejs` provide which supports the same buildplan config. See heroku/buildpacks-nodejs#1169 for more context.
mars
approved these changes
Sep 8, 2025
| // component buildpacks responsible for installing dependencies for the detected | ||
| // package manager (i.e.; npm, pnpm, or Yarn). This needs to be disabled so that | ||
| // the build process can be deferred to the release-build phase. | ||
| enabled = false |
There was a problem hiding this comment.
Having this enabled configuration now belong to heroku/nodejs in general seems potentially confusing. Maybe this flag should be given a new name like build_scripts_enabled?
heroku-linguist bot
added a commit
that referenced
this pull request
Sep 8, 2025
## heroku/static-web-server - No changes. ## heroku/website ### Changed - Updated `heroku/static-web-server` to `1.0.8`. - Updated `heroku/website-public-html` to `1.0.8`. ## heroku/website-ember ### Changed - Use `heroku/nodejs` buildplan entry for Node.js buildpack. ([#49](#49)) ## heroku/website-nodejs ### Changed - Updated `heroku/nodejs` to `5.0.0`. ([#49](#49)) - Updated `heroku/static-web-server` to `1.0.8`. - Updated `heroku/website-ember` to `1.0.8`. ## heroku/website-public-html - No changes.
Merged
heroku-linguist bot
added a commit
that referenced
this pull request
Sep 8, 2025
## heroku/static-web-server - No changes. ## heroku/website ### Changed - Updated `heroku/static-web-server` to `1.0.8`. - Updated `heroku/website-public-html` to `1.0.8`. ## heroku/website-ember ### Changed - Use `heroku/nodejs` buildplan entry for Node.js buildpack. ([#49](#49)) ## heroku/website-nodejs ### Changed - Updated `heroku/nodejs` to `5.0.0`. ([#49](#49)) - Updated `heroku/static-web-server` to `1.0.8`. - Updated `heroku/website-ember` to `1.0.8`. ## heroku/website-public-html - No changes. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v5, the following provides are no longer used:
node_build_scriptsThis is replaced by the
heroku/nodejsprovide which supports the same buildplan config.See heroku/buildpacks-nodejs#1169 for more context.
W-19524996