Conversation
eablack
changed the title
michaelmalave
approved these changes
Apr 15, 2026
Contributor
michaelmalave
left a comment
michaelmalave
left a comment
There was a problem hiding this comment.
One comment on a global rule. Other than that the changes look good.
…iles Removes extra semicolons that were flagged as errors by the linter and applies other lint-related formatting fixes to maintain consistency across the codebase.
eablack
force-pushed
the
eb/lint-fixes-lib
branch
from
676f6df to
73770e8
Compare
The _useSSH getter should return undefined when uri is not set, not null. This aligns with TypeScript conventions where optional properties default to undefined, and fixes a failing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes extra semicolons that were flagged as linting errors in the lib directory and applies additional lint-related formatting fixes to maintain code consistency across the codebase. This PR specifically addresses:
src/lib/addons/destroy-addon.tsandsrc/lib/container/docker-helper.tsforEachtofor...offor better performanceno-inner-declarationsESLint rule exceptionType of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
All changes are formatting-related and do not modify runtime behavior. The linter now passes without semicolon errors.
Steps:
npm run lintto verify all semicolon errors are resolvedRelated Issues
Part of a series of PRs to reduce what is implemented in #3661