Skip to content

Patch nginx so it does graceful shutdown on SIGTERM and fast shutdown…#88

Open
syastrov wants to merge 2 commits into
heroku:mainfrom
Boligportal:main
Open

Patch nginx so it does graceful shutdown on SIGTERM and fast shutdown…#88
syastrov wants to merge 2 commits into
heroku:mainfrom
Boligportal:main

Conversation

@syastrov

@syastrov syastrov commented Aug 6, 2021

Copy link
Copy Markdown

… on SIGQUIT.

Fixes #31

I tested manually that this works.

Based on #56

@syastrov

syastrov commented Nov 3, 2021

Copy link
Copy Markdown
Author

@beanieboi Any chance of merging this?

@nenadfspartans

Copy link
Copy Markdown

@beanieboi Any update on this?

@jaGarcia

jaGarcia commented Feb 2, 2023

Copy link
Copy Markdown

Running into nginx seemingly not passing the SIGTERM call to the underlying spring/java process. Any way to get this PR merged?

@tkrevh

tkrevh commented Aug 19, 2024

Copy link
Copy Markdown

Could someone please merge this?
We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success.
Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

@nenadfilipovic

Copy link
Copy Markdown

Could someone please merge this? We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success. Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

Hi, I am using my fork for about two years now https://github.com/nenadfilipovic/heroku-buildpack-nginx, works without issues. You can add it via https://buildpack-registry.s3.amazonaws.com/buildpacks/nenadfilipovic/heroku-buildpack-nginx.tgz inside buildpacks list or by nenadfilipovic/heroku-buildpack-nginx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

graceful shutdowns

5 participants