Add EOL warnings for unsupported Node.js versions#1593
Closed
colincasey wants to merge 6 commits intomainfrom
Closed
Add EOL warnings for unsupported Node.js versions#1593colincasey wants to merge 6 commits intomainfrom
colincasey wants to merge 6 commits intomainfrom
Conversation
6 tasks
colincasey
force-pushed
the
ccasey/classic-eol-support
branch
2 times, most recently
from
37edc89 to
e63f109
Compare
- resolve-version uses nodejs-data crate types via git dependency - Inventory parsed as NodejsInventoryWithMetadata with release schedule - JSON output includes eol_date and fail_build fields - Default LTS read from inventory metadata (no more hardcoded value) - Bash scripts emit EOL warnings/errors based on resolved version metadata - Regenerated inventory with metadata section - Rebuilt resolve-version vendor binary
Switch libherokubuildpack to published =0.30.3 crate and nodejs-data to the ccasey/eol-support branch. Regenerate inventory with [schedule.vN] table format replacing [[releases]] array format.
colincasey
force-pushed
the
ccasey/classic-eol-support
branch
from
e63f109 to
d51fc59
Compare
Contributor
Author
|
closing this in favor of the stacked changes for #1621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve-versionbinary tonodejs-data-querywith two clap subcommands:supported-versions <inventory_path>— outputs JSON with current, active LTS, and maintenance LTS versionsresolve-version <inventory_path> <node_version> [--os] [--arch]— resolves version with EOL datanodejs-datacrate types (NodejsInventoryWithSchedule) via git dependency[[releases]]schedule formateol_dateandfail_buildfieldsnodejs-data-query supported-versions+jqinstead of grep/sed TOML parsingTest plan
cargo testpasses innodejs-data-query/make heroku-24-general TEST=testEolVersionWarningpassesW-21451598