Add eol warnings#1604
Closed
runesoerensen wants to merge 2 commits intomainfrom
Closed
Conversation
…ions - Add `inventory/schedule.json` from the upstream Node.js release schedule - Point `nodejs-data` dependency to `implement-eol-warnings-v2` branch to use `NodeReleaseSchedule` types - Replace `<lts_major_version>` CLI argument with `<schedule_path>`, and make `[node_version]` optional (defaults to newest supported LTS) - Add EOL warning to resolve-version JSON output when the resolved version has passed its end-of-life date - Add `output::warning` function to `lib/output.sh` for styled warnings - Simplify `install_nodejs` by removing hardcoded LTS version Update default node version assertion
ae841a7 to
40dbd3d
Compare
Contributor
|
closing this in favor of the stacked changes for #1621 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve-versionto use shared types (NodejsInventory,NodejsArtifact,VersionRange) from thenodejs-datacrate being extracted in Extract shared Node.js types into nodejs-data crate buildpacks-nodejs#1328, replacing local parallel implementationsCommit progression
This draft PR contains two commits mostly because it's intended as a PoC, but they could be split into separate PRs before merging.
bca6a31 - Use
nodejs_datafrom the CNB inresolve-versionAdopts the shared
nodejs-datacrate from theccasey/nodejs-data-cratebranch. Replaces the localRequirementstruct andNodeInventory/NodeArtifacttype aliases withVersionRange,NodejsInventory, andNodejsArtifactfrom the shared crate. The wide-range/LTS-bound resolution logic stays local for now, bridging tonode-semvertypes viaVersionRange's Display output.40dbd3d - Derive LTS version from release schedule and warn on EOL Node.js versions
Switches the
nodejs-datadependency to theimplement-eol-warnings-v2branch to pick upNodeReleaseScheduletypes. Addsinventory/schedule.json(from the upstream Node.js release schedule) and changes theresolve-versionCLI to accept a schedule path instead of a hardcoded LTS major version. The binary now:lts_major_version="24"from the shell scripts)[node_version]optional — when omitted, defaults to the newest supported LTSAlso adds an
output::warningfunction tolib/output.shfor styled warning output.Follow-up
nodejs-datacrate, removing thenode-semverbridge code inresolve-version.inventory/schedule.jsonfile.