Remove Heroku-20 support #1591
Merged
Remove Heroku-20 support #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/remove-heroku-20-and-other-cleanup-tasks
branch
4 times, most recently
from
cd85c95 to
c6b0947
Compare
Ruby 3+ ships with a bundler version and Ruby 3.1 ships with Bundler 2.5: ``` $ /Users/rschneeman/.rubies/ruby-3.1.6/bin/bundle -v Bundler version 2.5.11 ``` I think we could also remove the 2.3 and 2.4 bundler versions from the hash, but would need to check observability to be sure. It's not hurting things for now.
There's only one test in `installers/`, and it's easier to run all "helpers" at once this way.
schneems
force-pushed
the
schneems/remove-heroku-20-and-other-cleanup-tasks
branch
2 times, most recently
from
9d97819 to
9d076d7
Compare
Code was added in Ruby ~2.5 and never moved 5dbc840
```
$ irb
irb(main):001> Gem::Version.new("2.3.1") > Gem::Version.new("2.3")
=> true
```
schneems
force-pushed
the
schneems/remove-heroku-20-and-other-cleanup-tasks
branch
from
9d076d7 to
eca1f20
Compare
Added in eac7584 and removed some time later, we have libyaml on the system and this is a no-op. https://devcenter.heroku.com/articles/stack-packages
colincasey
reviewed
May 13, 2025
colincasey
reviewed
May 13, 2025
colincasey
reviewed
May 14, 2025
colincasey
reviewed
May 14, 2025
colincasey
approved these changes
May 14, 2025
There was a problem hiding this comment.
@schneems I've got a couple questions for you but they aren't blockers.
Co-authored-by: Colin Casey <[email protected]> Signed-off-by: Richard Schneeman <[email protected]>
|
Addressed all comments. I'm going to wait for a good time to merge/deploy so I can rollback if I cleaned a little too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Heroku-20 is has reached end-of-life:
https://devcenter.heroku.com/changelog-items/3230
Removed:
GUS-W-14707069