fix: update login state file for both keychain and .netrc#381
Merged
Conversation
k80bowman
force-pushed
the
k80/netrc-error-fix
branch
from
c33721f to
95e19b0
Compare
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for managing/using the login state file in .netrc mode. Previously this was only supported for keychain mode. This update should resolve an issue where users were not seeing a warning message running a command in keychain mode (without
HEROKU_NETRC_WRITE=true) after logging in in .netrc mode (withHEROKU_NETRC_WRITE=true).Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
We can't test this with the CLI using
npm link, it causes all sorts of TypeScript errors. Once this PR is merged I will release a beta that we can test.Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-20867320