Skip to content

fix(a11y): resolve empty link issue in HeroUIProCallout overlay link #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

fix(a11y): resolve empty link issue in HeroUIProCallout overlay link #5813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/docs/components/docs/heroui-pro-callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export const HeroUIProCallout = () => {
return (
<div className="relative w-full max-w-[12rem] flex flex-col items-center border border-default/60 hover:border-default/90 rounded-xl py-6 px-2 cursor-pointer">
<div>
<p className="leading-[1.025] tracking-tight text-center text-large font-semibold">
<p
className="leading-[1.025] tracking-tight text-center text-large font-semibold"
id="callout-title"
>
Ship&nbsp;
<span className="bg-clip-text text-transparent bg-linear-to-b from-[#5EA2EF] to-[#0072F5]">
faster
Expand All @@ -26,7 +29,10 @@ export const HeroUIProCallout = () => {
<br />
components
</p>
<p className="text-center text-xs mt-2 px-3 font-medium text-default-500 dark:text-default-400 leading-tight">
<p
className="text-center text-xs mt-2 px-3 font-medium text-default-500 dark:text-default-400 leading-tight"
id="callout-description"
>
Discover 210+ stunning components by HeroUI
</p>
</div>
Expand All @@ -37,6 +43,7 @@ export const HeroUIProCallout = () => {
</div>
</div>
<NextLink
aria-labelledby="callout-title callout-description"
className="absolute inset-0 z-1"
href="https://heroui.pro/components?utm_source=heroui.com&utm_medium=callout"
onClick={handleClick}
Expand Down
Loading