Skip to content

Conversation

@wingkwong
Copy link
Member

@wingkwong wingkwong commented Oct 19, 2025

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information


Note

Introduce Checkbox and CheckboxGroup components with Tailwind-based styles, Storybook stories, and comprehensive docs/demos; export them from the React package.

  • React Components:
    • packages/react/src/components/checkbox: New compound Checkbox (Root, Control, Indicator, Content) with slot-based styling and default indicator; includes variants and stories.
    • packages/react/src/components/checkbox-group: New CheckboxGroup with variants and stories (default, custom indicator, indeterminate, validation, controlled, disabled).
    • Exports: Added checkbox and checkbox-group to components/index.ts.
  • Styles:
    • packages/styles/components/checkbox.css and checkbox-group.css: New BEM-style classes and states; imported in components/index.css.
  • Docs:
    • apps/docs/content/docs/components/checkbox.mdx: New Checkbox documentation with usage, anatomy, styling, states, and API.
    • Demos: Added apps/docs/src/demos/checkbox/* (basic, disabled, default-selected, controlled, indeterminate, with-label/description, render-props, form, custom-styles) and registered in apps/docs/src/demos/index.ts.}

Written by Cursor Bugbot for commit b694ea5. This will update automatically on new commits. Configure here.

@wingkwong wingkwong added the ♿ Scope: v3 Related to HeroUI v3 label Oct 19, 2025
@notion-workspace
Copy link

Checkbox component

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2025

⚠️ No Changeset found

Latest commit: b694ea5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
heroui Error Error Oct 28, 2025 4:17pm
heroui-sb Error Error Oct 28, 2025 4:17pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/HHT-252

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jrgarciadev jrgarciadev changed the base branch from v3 to alpha-36 October 30, 2025 14:21
@jrgarciadev jrgarciadev marked this pull request as ready for review October 30, 2025 14:23
@jrgarciadev jrgarciadev self-requested a review as a code owner October 30, 2025 14:23
@jrgarciadev jrgarciadev merged commit 91f1905 into alpha-36 Oct 30, 2025
1 of 4 checks passed
@jrgarciadev jrgarciadev deleted the feat/HHT-252 branch October 30, 2025 14:23
<CheckboxContext value={{slots, state: values}}>
{typeof children === "function" ? children(values) : children}
</CheckboxContext>
)}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Context Component Misuse Causes Runtime Error

The CheckboxContext is used directly as a JSX component instead of CheckboxContext.Provider. This causes a runtime error and prevents context values like slots and state from being passed down to child components.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♿ Scope: v3 Related to HeroUI v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants