Skip to content

Conversation

@jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Oct 26, 2025

Closes #

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information


Note

Overhauls the v3 design system: new semantic variants (card/chip/link/avatar), revamped styles/theme tokens, reduced-motion support, and updated docs/storybook demos.

  • Design System & Theme
    • Revamp theme variables (surfaces, soft colors, background-secondary/tertiary), shadows, and field tokens; remove old typography vars and borders by default.
    • Add global reduced-motion variant (reduce-motion) and integrate across components; export/import new variants/ CSS.
    • Update component CSS (accordion, avatar, button, card, chip, close-button, disclosure, input, kbd, link, popover, radio, separator, skeleton, switch, tabs, textarea, tooltip) with new radii, transitions, hovers, and focus utilities.
  • React Components
    • Card: switch to semantic variants (default, subtle, emphasis, strong, panel) and styles; stories updated.
    • Chip: replace type with color, add soft variant and size prop; stories updated.
    • Link: add underline and underlineOffset variants and asChild support; styles and stories updated.
    • Avatar: add variant (soft); styles and stories updated.
    • Accordion: rename outline to panel variant; stories updated.
    • Button/Spinner: add danger-soft variant; default spinner color set to accent; story tweaks.
    • Misc demos/stories: disclosure, radio-group, fieldset, kbd, skeleton, switch refined.
  • Docs
    • Avatar: add Variants section and API for variant.
    • Card: document new semantic variants and API; CSS classes updated.
    • Chip: document color/variant/size and compound styles; API updated.
    • Link: document underline variants/offset, asChild, and BEM classes.
    • Skeleton: add Grid and Single Shimmer examples.
    • Handbook: update colors/theming to new variables and calculations; composition uses Link.Root.
  • Storybook
    • Add Reduce Motion toolbar toggle and decorator; include Welcome page; adjust preview sorting and theming.

Written by Cursor Bugbot for commit b62ab5b. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2025

⚠️ No Changeset found

Latest commit: 7a6e0c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
heroui Ready Ready Preview Comment Nov 3, 2025 7:07pm
heroui-sb Ready Ready Preview Comment Nov 3, 2025 7:07pm

@jrgarciadev jrgarciadev marked this pull request as draft October 26, 2025 23:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/new-ds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

…5870)

* fix(component): checkbox build errors

* refactor(docs): simplify component usage by using compound pattern

* fix(component): checkbox build errors

* chore(docs): correct pattern description
@jrgarciadev jrgarciadev changed the base branch from alpha-36 to beta-1 November 3, 2025 19:06
@jrgarciadev jrgarciadev marked this pull request as ready for review November 3, 2025 19:06
@jrgarciadev jrgarciadev merged commit 5d4c385 into beta-1 Nov 3, 2025
2 of 3 checks passed
@jrgarciadev jrgarciadev deleted the feat/new-ds branch November 3, 2025 19:06
: {
width: `${(endOffset! - startOffset!) * 100}%`,
}),
}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: NaN Caused by Optional Thumb Percent Calculations

In SliderTrack and SliderFill, calculations for track fill and thumb positioning use non-null assertions on values from getThumbPercent?.(). If getThumbPercent is undefined, these calculations, including the startOffset fallback, can result in NaN. This leads to invalid CSS styles for positioning and sizing.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

♿ Scope: v3 Related to HeroUI v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants