-
-
Notifications
You must be signed in to change notification settings - Fork 2k
V3 Redesign #5851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 Redesign #5851
Conversation
…h new component structure
… to new default theme
…views; update card and disclosure styles for consistency
…nt documentation and implementation
…fects for icon opacity
…ton, disclosures updated
… and reduce motion effects
…s): include variants in package config and copy script
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ng and introduce new variants
…on instead of scale transformation
…nt backgrounds from layout components
…ted. Home page completed
…5870) * fix(component): checkbox build errors * refactor(docs): simplify component usage by using compound pattern * fix(component): checkbox build errors * chore(docs): correct pattern description
| : { | ||
| width: `${(endOffset! - startOffset!) * 100}%`, | ||
| }), | ||
| }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: NaN Caused by Optional Thumb Percent Calculations
In SliderTrack and SliderFill, calculations for track fill and thumb positioning use non-null assertions on values from getThumbPercent?.(). If getThumbPercent is undefined, these calculations, including the startOffset fallback, can result in NaN. This leads to invalid CSS styles for positioning and sizing.
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Note
Overhauls the v3 design system: new semantic variants (card/chip/link/avatar), revamped styles/theme tokens, reduced-motion support, and updated docs/storybook demos.
reduce-motion) and integrate across components; export/import newvariants/CSS.default,subtle,emphasis,strong,panel) and styles; stories updated.typewithcolor, addsoftvariant andsizeprop; stories updated.underlineandunderlineOffsetvariants andasChildsupport; styles and stories updated.variant(soft); styles and stories updated.panelvariant; stories updated.danger-softvariant; default spinner color set toaccent; story tweaks.variant.asChild, and BEM classes.Link.Root.Written by Cursor Bugbot for commit b62ab5b. This will update automatically on new commits. Configure here.