Beta 1 [v3] #5872
Open
Beta 1 [v3] #5872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor(component): compound and named pattern * refactor(component): tabs component naming consistency * docs(changelog): v3.0.0-alpha-36
* fix(component): support compound pattern in server component * fix(component): keep accordion and chip in sync with compound pattern * fix(component): type of forward refs * fix(calendar): temporary workaround for ref error * fix(storybook): imports * feat(checkbox): initial draft * refactor(styles): remove orientation * refactor: migration from dot notation to separted components to support RSC * refactor: migrate to React 19 ref pattern - remove forwardRef wrappers and explicit ref declarations from all components * chore(checkbox): revise checkbox story * feat(checkbox): checkmark & indeterminate * chore(styles): checkmark & indeterminate styles * refactor: provider context removed as it is not longer needed on react 19 * feat: made the migration smoother by still supporting the "dot" exports but adjusting the main compound component * fix: compound patter, radio group api, ref on react 19 * refactor(switch): split switch and switch-group into separate components following radio/radio-group pattern * chore(changelog): update v3.0.0-alpha.35 release notes and date * fix(page): update version label to reflect RSC support * chore(changelog): update examples to use new component names CardRoot and TabsRoot * refactor(checkbox): adopt latest component structure * chore: remove radio stories * refactor(checkbox): adopt new api and revised stories * refactor(checkbox-group): adopt new api and add stories * chore(checkbox-group): revise examples * chore(checkbox): separate checkbox group css * chore(styles): revise checkbox styels * fix(styles): add border for invalid * feat(checkbox): add invalid story * chore: sync changes from v3 redesign * refactor(checkbox): remove slots * refactor(checkbox): apply compound and named pattern * feat(docs): checkbox page * refactor(checkbox): remove use client * chore(docs): revise based on the latest revamp --------- Co-authored-by: Tianen Pang <[email protected]> Co-authored-by: Junior Garcia <[email protected]>
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
* fix(docs): update Link component to use Link.Root for consistency with new component structure * feat: light theme in progress, button, spearator & accordion adjusted to new default theme * feat: button and chip done * feat: enhance Skeleton component with new Grid and Single Shimmer previews; update card and disclosure styles for consistency * feat: update Kbd component styles and add Abbr support in stories * feat: avatar and chip updated * fix(accordion): adjust separator styling for consistency in accordion items * refactor: close button adjsuted * feat(link): add underline variants and offset options to Link component documentation and implementation * feat(link): enhance link component with hover state and transition effects for icon opacity * refactor: surfaces variables are now calculated by default, card, button, disclosures updated * refactor: update styles for various components to improve consistency and reduce motion effects * feat(storybook): add welcome story and update story order; feat(styles): include variants in package config and copy script * refactor: update accordion, card, and kbd components to enhance styling and introduce new variants * refactor(link): update hover underline effect to use opacity transition instead of scale transformation * refactor(styles): update background color variables and remove gradient backgrounds from layout components * refactor(storybook): enhance color stories by adding calculated color variants and removing deprecated soft colors * refactor(styles): introduce background quaternary color and update shadow variables for popover and tooltip components * feat: alert component created * refactor(alert-demo, x-profile-demo): simplify button usage and enhance layout alignment * feat: input otp * feat: inpuit otp docs * refactor(switch): enhance styling with improved transition timings and add box-shadow for active states * feat: home page design in progress * feat: add Surface component with context-based on-surface styling - Add Surface component with four variants (default, secondary, tertiary, quaternary) - Implement SurfaceContext to provide variant to child components - Update Input, TextArea, InputOTP, and RadioGroup to automatically detect Surface context - Components now apply on-surface styling when wrapped in Surface component - Add OnSurface stories for all affected components - Create comprehensive Surface documentation with examples - Add OnSurface demo examples to all component documentation pages - Update CSS classes to support on-surface modifier variants * feat: add Surface component documentation and update meta.json * feat(card): implement form handling in WithForm story using Form, Input, and Label components * feat(card): refactor WithForm to use Form component for improved form handling and submission * refactor(accordion): remove background class from stories and enhance AccordionRoot with SurfaceContext for elevated variant * refactor(accordion): update variant from elevated to surface across components and documentation * feat: add checkbox-group component and checkbox enhancements * feat(demo): add UIComponentsDemo to the DemoComponents * refactor: migrate Component.Root to Component in docs and demos - Update all component documentation files to use Component instead of Component.Root - Update all demo files to use simplified component syntax - Update API reference headers from Component.Root Props to Component Props - Exclude changelog files from migration as requested This change promotes the simpler and more elegant Component syntax while maintaining backward compatibility (both patterns are still supported). * style: update global styles and card component * feat(storybook): enhance color stories with new "On Surface" color variants and remove obsolete field color states * feat(demos): update chip component props from 'type' to 'color' and add "use client" directive in multiple demo files * feat(demos): add "use client" directive to basic button demo * refactor: theme variables update background color in dark mode * feat(demos): add "use client" directive to multiple demo files * feat(demos): add FieldError component to TextfieldDemo for improved validation feedback * fix(demo): update avatar images and names in avatar-group-demo for consistency * feat: listbox component preview created and documented * feat: selecte component created * feat: export React Aria components from rac module * feat: slider component created, documentation styles and content updated. Home page completed * fix(demo): correct spelling of "credits" in AlertDemo component * refactor(docs): simplify component usage by using compound pattern (#5870) * fix(component): checkbox build errors * refactor(docs): simplify component usage by using compound pattern * fix(component): checkbox build errors * chore(docs): correct pattern description * feat(docs): enhance component preview with intersection observer for lazy loading * feat(docs): enhance code block styling and functionality with isolated rendering option * chore(root): upgrade package manager * fix(docs): update image sources and enhance styling across various components --------- Co-authored-by: Tianen Pang <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…nent for improved readability
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…irective from Iconify component
| validationErrors, | ||
| validationDetails, | ||
| }) as ValidationResult, | ||
| [isInvalid], |
There was a problem hiding this comment.
Bug: Stale Validation State from Incomplete Dependencies
The useMemo for the validation object depends on isInvalid, validationErrors, and validationDetails, but its dependency array only includes isInvalid. This can cause stale validation state if validationErrors or validationDetails change without isInvalid triggering a re-computation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Note
Ships v3 Beta unifying component APIs into compound patterns, adds new components (Checkbox, Select, Surface, Header), overhauls styles/theme, and enhances Storybook with reduce-motion and new docs.
Accordion,Alert,Avatar,Button,Calendar,Card,CloseButton,Description,FieldError,Fieldset,Form,Input,Kbd,Label,Link,Popover,Radio/RadioGroup,Separator,Skeleton,Slider,Switch/SwitchGroup,Tabs,Text/TextArea/TextField.Checkbox+CheckboxGroup,Select(with sections/multi/async),ListBoxItem/ListBoxSection,Surface(context for on-surface),Header; revampInputOTPand ListBox stories.variants/reduce-motionutility.Written by Cursor Bugbot for commit 61237fd. This will update automatically on new commits. Configure here.