Skip to content

Conversation

@abdallhsamy
Copy link

No description provided.

@vercel
Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-variants-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 7:28am

Copy link
Collaborator

@mskelton mskelton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of issues with this PR that would need to be addressed to merge. Also, a simpler and more real world example would be ideal.


import {title} from "@/components/primitives";

export default function Home() => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invalid syntax.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be page.tsx file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are mixing the function keyword with arrow function => syntax.

# /components/primitives
import { tv } from "tailwind-variants";

export const title = tv({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really the best example IMO. A example for a button or something similar would be better than a gradient like this, as this makes use of a lot of Tailwind arbitrary variants, which isn't something I'd like to encourage in the Tailwind Variants docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants