Skip to content

fix for empty vectors in simulations #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivborissov merged 1 commit into from
Sep 16, 2025
Merged

fix for empty vectors in simulations #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/solution_interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
############################ Accessing Solution Values #####################

observables(sr::SimResult) = observables(sr.sim)
observables(sim::Simulation) = collect(keys(sim.vals.u[1]))
observables(sim::Simulation) = collect(LabelledArrays.symnames(eltype(sim.vals.u)))
observables(sim::MCResult) = observables(sim[1])
#parameters(sim::SimResult) = sim.scenario.prob.p

Expand Down
13 changes: 12 additions & 1 deletion src/types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,23 @@ end

# copy fix is tmp needed not to rewrite SavedValues with new simulation
Simulation(sv::SavedValues, params, status) = Simulation(
DiffEqArray(copy(sv.u),copy(sv.t)),
SciMLBase.RecursiveArrayTools.DiffEqArray(sv),
copy(sv.scope),
params,
Symbol(status)
)

function SciMLBase.RecursiveArrayTools.DiffEqArray(sv::SavedValues, p=nothing; safetycopy=true)
vec = sv.u
ts = sv.t
vars = !isempty(vec) ? collect(symbols(vec[1])) : []
if safetycopy
return SciMLBase.RecursiveArrayTools.DiffEqArray(copy(vec), copy(ts), p; variables = vars)
else
return SciMLBase.RecursiveArrayTools.DiffEqArray(vec, ts, p; variables = vars)
end
end

status(s::Simulation) = s.status
times(s::Simulation) = s.vals.t
vals(s::Simulation) = s.vals.u
Expand Down
Loading