Remove duplicate cosmos event emission in EVM transaction processing

[ai-chen2050]

Description

The change removes ctx.EventManager().EmitEvents() call that was duplicating events already emitted in the temporary context. This prevents double emission of the same events during EVM transaction execution. The events are already properly handled in the temporary context's commit phase.

That CacheContext would emit event internally in version 0.5.0+ of cosmos, which

func (c Context) CacheContext() (cc Context, writeCache func()) {
	cms := c.MultiStore().CacheMultiStore()
	cc = c.WithMultiStore(cms).WithEventManager(NewEventManager())

	writeCache = func() {
		c.EventManager().EmitEvents(cc.EventManager().Events())
		cms.Write()
	}

	return cc, writeCache
}
https://github.com/cosmos/cosmos-sdk/blob/v0.47.10/types/context.go#L294-L304

---

Closes #2

Summary by CodeRabbit

• Chores

  • Removed the Go vulnerability check from the automated workflow.

• Refactor

  • Updated transaction processing to no longer emit events from temporary contexts after post-transaction processing.

[coderabbitai]

Walkthrough

The pull request removes a redundant event emission in the EVM state transition logic to prevent double event emission after a transaction is processed. Additionally, the CI workflow is updated by deleting the "Go vulnerability check" step from the dependencies workflow file.

Changes

File(s)	Change Summary
.github/workflows/dependencies.yml	Removed "Go vulnerability check" step from workflow.
x/evm/keeper/state_transition.go	Removed redundant event emission after transaction commit.

Sequence Diagram(s)

sequenceDiagram
    participant MainCtx as Main Context
    participant TmpCtx as Temp Context
    participant PostTx as PostTxProcessing

    MainCtx->>TmpCtx: Create CacheContext
    TmpCtx->>PostTx: Execute PostTxProcessing
    PostTx-->>TmpCtx: Success
    TmpCtx->>MainCtx: Commit (includes internal event emission)
    Note over MainCtx: No manual event emission after commit

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Prevent double event emission after CacheContext commit (Issue #2)	✅

Poem

A bug in the meadow, events doubled in glee,
The rabbit hopped in, and fixed what should be.
Now events are not echoed, the logs are all neat,
With workflows less cluttered, our chain can compete!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24758ef and c02274b.

📒 Files selected for processing (2)

• .github/workflows/dependencies.yml (0 hunks)
• x/evm/keeper/state_transition.go (0 hunks)

💤 Files with no reviewable changes (2)

• .github/workflows/dependencies.yml
• x/evm/keeper/state_transition.go

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.