Skip to content

Conversation

apricote
Copy link
Member

Changes the time format from time.UnixDate to time.DateTime + timezone.

  • Old: Mon Jan 10 15:04:05 MST 2006
  • New: 2006-01-10 15:04:05 MST

I personally find this much easier to read.

Changes the time format from `time.UnixDate` to `time.DateTime +
timezone`.

- Old: `Mon Jan 10 15:04:05 MST 2006`
- New: `2006-01-10 15:04:05 MST`
@apricote apricote self-assigned this Oct 16, 2025
@apricote apricote requested a review from a team as a code owner October 16, 2025 08:30
@lukasmetzner
Copy link
Contributor

👍 on the time format

@phm07
Copy link
Contributor

phm07 commented Oct 17, 2025

+1 from me as well.
Is this a breaking change?

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.78%. Comparing base (7aeee17) to head (246a41e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
+ Coverage   69.76%   69.78%   +0.02%     
==========================================
  Files         271      271              
  Lines       12302    12302              
==========================================
+ Hits         8582     8585       +3     
+ Misses       2913     2911       -2     
+ Partials      807      806       -1     
Flag Coverage Δ
e2e 52.40% <100.00%> (+0.02%) ⬆️
unit 63.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apricote
Copy link
Member Author

Is this a breaking change?

In theory yes, as is every new property we add to describe or list outputs.

I hope no one was parsing the old format.

Maybe we should make it a global option and change the default? Then anyone can move back to the old format if they want to.

@phm07
Copy link
Contributor

phm07 commented Oct 17, 2025

I think a date format option would be a little overkill. It is probably safe to assume that users use JSON or YAML formats when working with raw data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants