-
Notifications
You must be signed in to change notification settings - Fork 112
fix: missing location config via node name and server id #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
feaa715 to
83ccec2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
===========================================
+ Coverage 37.62% 71.64% +34.01%
===========================================
Files 17 17
Lines 1483 1481 -2
===========================================
+ Hits 558 1061 +503
+ Misses 905 336 -569
- Partials 20 84 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there an easy way to test this code? |
I could think of an integration test where we spin up a test server and a fake metadata server, to test all four paths of |
When merging our two binaries into one, the option to configure the location on startup via KUBE_NODE_NAME or HCLOUD_SERVER_ID was not implemented. Missing configuration options in docs: https://github.com/hetznercloud/csi-driver/blob/637e45cf283f384c455125bbc7f3931328f5e80b/docs/kubernetes/README.md?plain=1#L154-L155 Fixes #1149
1fcd72a to
a46ea57
Compare
ff55460 to
bb65065
Compare
When merging our two binaries into one, the option to configure
the location on startup via KUBE_NODE_NAME or HCLOUD_SERVER_ID was not implemented.
Missing configuration options in docs:
csi-driver/docs/kubernetes/README.md
Lines 154 to 155 in 637e45c
Fixes #1149