feat: add support for Storage Boxes #684

apricote · 2025-08-06T07:37:40Z

We collect all changes for the Storage Box support (#675) in this PR. It will only be merged when everything is implemented through smaller pull requests targetting the storage-boxes branch.

Closes #675

codecov · 2025-08-06T07:38:36Z

Codecov Report

❌ Patch coverage is 80.24691% with 112 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.52%. Comparing base (68c6e74) to head (be9038e).

Files with missing lines	Patch %	Lines
hcloud/storage_box.go	72.53%	41 Missing and 12 partials ⚠️
hcloud/storage_box_subaccount.go	81.02%	19 Missing and 7 partials ⚠️
hcloud/storage_box_snapshot.go	84.31%	11 Missing and 5 partials ⚠️
hcloud/schema.go	87.50%	6 Missing ⚠️
hcloud/storage_box_type.go	86.04%	5 Missing and 1 partial ⚠️
hcloud/schema_gen.go	78.26%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
+ Coverage   78.24%   78.52%   +0.27%     
==========================================
  Files          55       59       +4     
  Lines        5039     5603     +564     
==========================================
+ Hits         3943     4400     +457     
- Misses        827      911      +84     
- Partials      269      292      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hcloud/storage_box.go

hcloud/schema/storage_box.go

hcloud/storage_box.go

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box.go

jooola

I'll do another pass when the additional changes from #745 are merged.

hcloud/storage_box_snapshot.go

hcloud/storage_box_subaccount.go

hcloud/storage_box_type.go

Adds support for the new Hetzner API with a shallow copy of the original client. The new options `WithHetznerEndpoints` is marked as experimental for now. --------- Co-authored-by: Julian Tölle <[email protected]>

We can use the same API endpoint here, as this is a local server for testing, where we define the responses ourselves.

Reference to API docs: https://docs.hetzner.cloud/reference/hetzner#storage-box-types --------- Co-authored-by: Julian Tölle <[email protected]>

SnapshotLimit and AutomaticSnapshotLimits were both pointers, which is not necessary.

Adds the new Storage Box client with the necessary types and CRUD operations. API Reference: https://docs.hetzner.cloud/reference/hetzner#storage-boxes --------- Co-authored-by: Julian Tölle <[email protected]>

Adds support for Storage Box snapshots. API Reference: https://docs.hetzner.cloud/reference/hetzner#snapshots

Adds support for Storage Box subaccounts. API Reference: https://docs.hetzner.cloud/reference/hetzner#subaccounts

Adds support for Storage Box subaccount actions. API Reference: https://docs.hetzner.cloud/reference/hetzner#subaccount-actions

`snapshot_limit` and `automatic_snapshot_limit` are both nullable. We implemented them as required.

This PR adds missing schema conversion functions and makes some conversions more consistent with other resources

`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.

Co-authored-by: Jonas L. <[email protected]>

jooola · 2025-10-17T09:08:37Z

ℹ️ I am currently fixing a bunch of things here.

jooola · 2025-10-17T12:51:39Z

ℹ️ I am currently fixing a bunch of things here.

Done, please see #752

Additional fixes for the storage boxes implementation.

jooola · 2025-10-17T13:14:17Z

hcloud/storage_box.go

+// GetByID retrieves a [StorageBox] by its ID. If the [StorageBox] does not exist, nil is returned.
+func (c *StorageBoxClient) GetByID(ctx context.Context, id int64) (*StorageBox, *Response, error) {


Should we include links to the upstream documentation for each client methods?

Are we releasing this as experimental or not?

apricote assigned lukasmetzner Aug 6, 2025

apricote added the Feature label Aug 6, 2025

lukasmetzner force-pushed the storage-boxes branch from 992641b to 2d340eb Compare August 20, 2025 08:57

phm07 reviewed Aug 20, 2025

View reviewed changes

hcloud/storage_box.go Show resolved Hide resolved

phm07 reviewed Aug 20, 2025

View reviewed changes

hcloud/schema/storage_box.go Outdated Show resolved Hide resolved

lukasmetzner force-pushed the storage-boxes branch from ff07920 to aa5a527 Compare August 26, 2025 09:41

phm07 reviewed Sep 3, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

phm07 reviewed Sep 5, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Show resolved Hide resolved

hcloud/storage_box_snapshot.go Show resolved Hide resolved

hcloud/storage_box_subaccount.go Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Show resolved Hide resolved

phm07 reviewed Sep 8, 2025

View reviewed changes

hcloud/storage_box_snapshot.go Outdated Show resolved Hide resolved

phm07 force-pushed the storage-boxes branch from ee914b1 to 39b8d99 Compare September 18, 2025 09:55

phm07 reviewed Sep 18, 2025

View reviewed changes

hcloud/storage_box_subaccount.go Outdated Show resolved Hide resolved

phm07 force-pushed the storage-boxes branch from 39b8d99 to 8c628b8 Compare September 19, 2025 10:59

lukasmetzner force-pushed the storage-boxes branch from a4842c1 to 20e0a5f Compare October 9, 2025 06:54

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

hcloud/storage_box.go Outdated Show resolved Hide resolved

jooola reviewed Oct 16, 2025

View reviewed changes

lukasmetzner force-pushed the storage-boxes branch 2 times, most recently from a00ef9f to 8a77911 Compare October 17, 2025 06:49

lukasmetzner marked this pull request as ready for review October 17, 2025 07:02

lukasmetzner requested a review from a team as a code owner October 17, 2025 07:02

lukasmetzner and others added 3 commits October 17, 2025 10:57

feat: add support for Hetzner API endpoint (#683)

eaab4df

Adds support for the new Hetzner API with a shallow copy of the original client. The new options `WithHetznerEndpoints` is marked as experimental for now. --------- Co-authored-by: Julian Tölle <[email protected]>

fix: add Hetzner endpoint to test utils (#686)

b5f5b4e

We can use the same API endpoint here, as this is a local server for testing, where we define the responses ourselves.

feat: add support for Storage Box Types (#687)

1b6a3ec

Reference to API docs: https://docs.hetzner.cloud/reference/hetzner#storage-box-types --------- Co-authored-by: Julian Tölle <[email protected]>

lukasmetzner and others added 25 commits October 17, 2025 10:57

fix: snapshot limits pointers (#697)

31bd229

SnapshotLimit and AutomaticSnapshotLimits were both pointers, which is not necessary.

feat: Storage Box CRUD operations (#694)

fe9578b

Adds the new Storage Box client with the necessary types and CRUD operations. API Reference: https://docs.hetzner.cloud/reference/hetzner#storage-boxes --------- Co-authored-by: Julian Tölle <[email protected]>

feat: Storage Box snapshots (#700)

a078128

Adds support for Storage Box snapshots. API Reference: https://docs.hetzner.cloud/reference/hetzner#snapshots

feat: Storage Box actions (#701)

b007f44

feat: Storage Box subaccounts (#704)

e3599f0

Adds support for Storage Box subaccounts. API Reference: https://docs.hetzner.cloud/reference/hetzner#subaccounts

feat: Storage Box subaccount actions (#705)

666ffc6

Adds support for Storage Box subaccount actions. API Reference: https://docs.hetzner.cloud/reference/hetzner#subaccount-actions

fix: storage box type snapshot limits are nullable (#706)

69009c7

`snapshot_limit` and `automatic_snapshot_limit` are both nullable. We implemented them as required.

fix: update requests schema (#709)

89a22df

test: storage box and storage box type schema test

a8d2a63

fix: missing methods in generated interface

c0c9e05

feat: map Hetzner API's day_of_week to Go's time.Weekday (#716)

2d0d768

refactor(storage-box): schema conversion functions (#718)

e3dbb28

This PR adds missing schema conversion functions and makes some conversions more consistent with other resources

fix: export missing schema functions

ca80217

fix: description should be optional

856b89c

fix: subresources contain parent (#719)

e04a97c

`hcloud.StorageBox` is part of `hcloud.StorageBoxSubaccount` and `hcloud.StorageBoxSnapshot`. Therefore, we can remove the storage box reference from the function parameters.

refactor: subaccount access settings create opts (#726)

cd5a50a

feat: storage box api changes (#745)

ddd2990

refactor(storage-box): use getByIDOrName helper

7496d17

refactor: parse FromSchema directly in return call

d390bed

feat: remove pointer from descriptions in create calls

1f8b000

feat(snapshot): description is always returned

c8264e8

refactor: print full request path in one line

edadcf3

Co-authored-by: Jonas L. <[email protected]>

refactor(storage-box): url query parameter encoding

1c91080

Co-authored-by: Jonas L. <[email protected]>

feat(storage-box): delete protection optional

6e0afa7

feat(storage-box): use empty Username for init phase

bf3ac97

jooola force-pushed the storage-boxes branch from 8547e97 to bf3ac97 Compare October 17, 2025 08:57

fix: storage boxes fixes (#752)

be9038e

Additional fixes for the storage boxes implementation.

jooola reviewed Oct 17, 2025

View reviewed changes

		// GetByID retrieves a [StorageBox] by its ID. If the [StorageBox] does not exist, nil is returned.
		func (c StorageBoxClient) GetByID(ctx context.Context, id int64) (StorageBox, *Response, error) {

feat: add support for Storage Boxes #684

Are you sure you want to change the base?

feat: add support for Storage Boxes #684

Uh oh!

Conversation

apricote commented Aug 6, 2025

Uh oh!

codecov bot commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jooola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jooola commented Oct 17, 2025

Uh oh!

jooola commented Oct 17, 2025

Uh oh!

jooola Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Aug 6, 2025 •

edited

Loading