Skip to content

Conversation

jooola
Copy link
Member

@jooola jooola commented Oct 15, 2025

Adds the (&Server{}).PrivateNetFor(&Network{}) and (&LoadBalancer{}).PrivateNetFor(&Network{}) methods to retrieve the private network attachment information.

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.38%. Comparing base (9b89d96) to head (8aa5847).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
+ Coverage   78.27%   78.38%   +0.10%     
==========================================
  Files          55       55              
  Lines        5023     5039      +16     
==========================================
+ Hits         3932     3950      +18     
+ Misses        824      822       -2     
  Partials      267      267              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Adds the `(&Server{}).PrivateNetFor(&Network{})` and `(&LoadBalancer{}).PrivateNetFor(&Network{})` methods to retrieve the private network assignation information.
@jooola jooola force-pushed the server-private-network branch from 1b91c37 to f035730 Compare October 15, 2025 14:00
@jooola jooola changed the title feat: add method to retrieve a server network assignation feat: retrieve a server or load balancer network assignation Oct 15, 2025
@jooola jooola marked this pull request as ready for review October 15, 2025 14:02
@jooola jooola requested a review from a team as a code owner October 15, 2025 14:02
@apricote apricote changed the title feat: retrieve a server or load balancer network assignation feat: retrieve a server or load balancer network assignment Oct 15, 2025
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine 👍

@jooola jooola changed the title feat: retrieve a server or load balancer network assignment feat: retrieve a server or load balancer network attachment Oct 15, 2025
@jooola jooola merged commit 9da946b into main Oct 15, 2025
4 of 5 checks passed
@jooola jooola deleted the server-private-network branch October 15, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants