refactor(image): move image data sources to Plugin Framework

[jooola]

Related to #752

[codecov]

Codecov Report

❌ Patch coverage is 79.50311% with 66 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.15%. Comparing base (83c0bfd) to head (78aeb61).

Files with missing lines	Patch %	Lines
internal/image/data_source.go	73.36%	33 Missing and 16 partials ⚠️
internal/image/data_source_list.go	83.00%	9 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   73.00%   73.15%   +0.15%     
==========================================
  Files         113      115       +2     
  Lines       12639    12751     +112     
==========================================
+ Hits         9227     9328     +101     
- Misses       2343     2344       +1     
- Partials     1069     1079      +10     

Flag	Coverage Δ
e2e	73.15% <79.50%> (+0.15%)	⬆️
unit	37.80% <42.23%> (-0.18%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[apricote]

🚀

[jooola]

The upgrade tests are failing, because of a difference between the versions. Some of the diffs are expected, but some other I don't know if we want fix the values or stay backward compatible at all costs.

// Image list
                  ~ images             = [
                      ~ {
                          ~ deprecated   = "" -> null
                            id           = 40093059
                            name         = "lamp"
                          - selector     = ""
                            # (8 unchanged attributes hidden)
                        },

// Image single
                    id                 = 161547269
                  ~ include_deprecated = false -> null
                    name               = "ubuntu-24.04"
                  ~ with_architecture  = "x86" -> null
                    # (13 unchanged attributes hidden)

For the users provided options, I think its fine to change them.

For the deprecated attribute I am unsure if we still want to roll with this fix.

[apricote]

I think the shown changes are fine, all are basically the same in the terraform type system.

For the with_architecture diff: It looks to me like you missed the default in the new schema. This should be set for backwards compatibility.

[jooola]

For the with_architecture diff: It looks to me like you missed the default in the new schema. This should be set for backwards compatibility.

Data sources do not support defaults. I was only able to document the defaults in the markdown description, and set the default in the code directly.

I'd argue because it is a user input used to filter the result, it is fine to have null when it is unset.