Skip to content

Change overall progress to be the minimum rather than average #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coopermor wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change overall progress to be the minimum rather than average #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/work/fking/masteringmixology/Goal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ public void recalculate(MasteringMixologyConfig config, Client client) {
.orElse(0);
itemsAffordable = Math.min(minAffordable, rewardQuantity);

// Overall progress is the average of all component progress
// Overall progress is the minimum of all component progress
// as you can't buy rewards without completion of all components
overallProgress = componentDataMap.values().stream()
.mapToDouble(data -> data.percentageToGoal)
.average()
.min()
.orElse(0.0);
}

Expand Down