Fix Alembic quick-action sound effect's timing - #125
Merged
Conversation
Adds a manual found_gem (the sound effect that plays when a quick-action is available) sound effect to play at the correct time, when Alembic is highlighted green, not after.
Contributor
Author
|
|
Contributor
Author
|
Simplified the logic of this PR and fixed the double sound effect bug. Should be good to go. |
Owner
|
Can you also add a check if the player is in the mixology lab? Just as a failsafe |
Contributor
Author
|
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current game, the sound effect for Alembic plays after the quick-action has gone away. This is unlike the quick-action sound effect for Agitator, which plays at the correct time, or at least you can click the game when the effect plays and you'll get the quick action.
This PR fixes Alembic's quick-action sound effect to play when the quick-action is available and it's highlighted green.
In other words, the sound effect plays at the correct time now.