Initial groundwork for playing tones#164
Conversation
a-sommer
commented
Sep 24, 2022
- Added tonePlayer, concrete class for playing tones (in progress)
- Modified PlatformPlayer if/else to route x-tone-seq correctly
- Added initial implementations to Nokia Sound (in progress)
- Added tonePlayer, concrete class for playing tones (in progress) - Modified PlatformPlayer if/else to route x-tone-seq correctly - Added initial implementations to Nokia Sound (in progress)
|
Not a bad start. If you need any help with the Nokia formats, Just let me know. I wrote a little program to convert the music from Munkiki's Castles to MIDI for someone a few months back. Not that I recommend converting it to MIDI, but I can help with the formats. I'd recommend not catching those exceptions, but declaring them thrown. We've found that some games use exceptions for ordinary control flow. If we're going to support more formats (someone is or was working on adpcm support) we might want to replace that if/else chain with a more readable switch, something like |
|
Thanks! I appreciate it. I'll make those changes you recommend, and I'll reach out if I need help with the Nokia formats. |