feat: support ESM plugins or plugins with named exports#221
Open
calfzhou wants to merge 3 commits intohexojs:masterfrom
Open
feat: support ESM plugins or plugins with named exports#221calfzhou wants to merge 3 commits intohexojs:masterfrom
calfzhou wants to merge 3 commits intohexojs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check list
Description
This PR adds support for loading plugins that use ESM-style exports (interop) or named exports.
Previously, the renderer assumed that
require('plugin-name')would directly return the plugin function. However, some modern plugins or dual-mode packages might export the plugin function under adefaultproperty or a specific named export.With this change, users can now specify an
importproperty in the plugin configuration to choose which export to use.Logic:
importkey (or defaults to'default'), it tries to use that property.Example Config:
Additional information
README.mdwith usage examples for the new feature.