Ignore images within 'do not render' class #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do we have better solution for this feature? |
tomap
requested changes
Feb 25, 2019
Contributor
tomap
left a comment
tomap
left a comment
There was a problem hiding this comment.
I would not call the class do-not-render, but rather fancybox-disable of something like that
Because you are not disabling the rendering of the image, just the execution of fancybox
mrjohannchang
force-pushed
the
pr-do-not-render
branch
from
cde1860 to
a16843a
Compare
mrjohannchang
force-pushed
the
pr-do-not-render
branch
from
a16843a to
98a5aa6
Compare
Contributor
Author
|
Hi @tomap, done. |
Contributor
|
See #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
img tags which has class="do-not-render" attribute would be ignored by the parser in case one would like to exclude particular images from Fancybox.