-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: display translation progress in language names #2353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
✅ Theme thumbnails validation completed. |
yoshinorin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: yoshinorin <[email protected]>
Signed-off-by: yoshinorin <[email protected]>
Signed-off-by: yoshinorin <[email protected]>
stevenjoezhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that the current display may not be intuitive enough, and users might not clearly understand the meaning of the percentage. It might be better to display something like "中文(已翻译 80%)" or show the translation progress on hover.
yes, it will be better. I'm afraid that it will too long. And need to translate and stored the text "translated".
now the component lang-select use native , I haven't found the method to add hover. maybe I will try to implement the precious one. |
Check List
Please read and check followings before submitting a PR.
Others (Update, fix, translation, etc...)
enEnglishfeat: display translation progress in language names (7231abd)
add script to get translation progress from Crowdin (6c8464f)
ci: add workflow step to get translations progress (cec7e73)
chore: update eslintrc to meet eslint-plugin-node require (52ee164)