Skip to content

Conversation

@uiolee
Copy link
Member

@uiolee uiolee commented Feb 16, 2025

Check List

Please read and check followings before submitting a PR.

  • Others (Update, fix, translation, etc...)

    • Languages:
    • en English
  • feat: display translation progress in language names (7231abd)

  • add script to get translation progress from Crowdin (6c8464f)

  • ci: add workflow step to get translations progress (cec7e73)

  • chore: update eslintrc to meet eslint-plugin-node require (52ee164)

image

Screenshot_20250216_114512

@github-actions github-actions bot added the infra infrastructure, configuration of this repo label Feb 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025

✅ Theme thumbnails validation completed.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@stevenjoezhang stevenjoezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned that the current display may not be intuitive enough, and users might not clearly understand the meaning of the percentage. It might be better to display something like "中文(已翻译 80%)" or show the translation progress on hover.

@uiolee
Copy link
Member Author

uiolee commented Sep 4, 2025

I'm concerned that the current display may not be intuitive enough, and users might not clearly understand the meaning of the percentage. It might be better to display something like "中文(已翻译 80%)"

yes, it will be better. I'm afraid that it will too long. And need to translate and stored the text "translated".

show the translation progress on hover.

now the component lang-select use native , I haven't found the method to add hover. maybe I will try to implement the precious one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra infrastructure, configuration of this repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants