Skip to content

(WIP) refactor gpu allocator selection for vulkan #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shailpatels
Copy link

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Unsure why the function to select the optimal allocator was causing an issue, changed it something simpler but working to get the examples running and so i could work on testing swapchain recreation

Seems like an interaction with nvidia and vulkan specifically, will try to understand what the original was doing better and why it was causing this error for me: #1352 so ideally the changes are smaller and I'm still using the same checks as before for selecting an allocator.

unsure why the function to select the optimal allocator
was causing an issue, changed it something simpler but working
to get the examples running and so i could work on testing
swapchain recreation
@shailpatels shailpatels marked this pull request as draft March 28, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant