sysgpu: implement select() intrinsic for HLSL, MSL, and SPIR-V #1436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
select()intrinsic for HLSL, MSL, and SPIR-V. It also fixes a missing boolean implementation in MSL.Fixes a panic when compiling shaders using WGSL
select().(cond ? true : false).metal::select(false, true, cond).emitBoolfor MSL (was previously commented out and not implemented), required forselectconditions using literals.OpSelect(OpCode 69).Left GLSL unimplemented for now as the test suite appears commented out in
test.zig, so I figured I wouldn't implement it.Tested Verified output generation locally for HLSL, MSL, and SPIR-V using a simple test case.
Validated runtime behavior for HLSL and SPIR-V, by rendering a checkered triangle (using
selectin the fragment shader) on Windows 11 with an AMD Radeon RX 7900 XTX.