Skip to content

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 15, 2025

Fixes #2437
Fixes #2435

TODO

  • fix asClass without instance
  • fix downstream plugins depending on classes
  • breaking change in method name builder (added first argument)
  • expose class splitting strategy
  • add casing options to method name and class name builders
  • rename method name and class name builders
  • rename stringCase interfaces?
  • add changelog for codegen-core fix local names

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

⚠️ No Changeset found

Latest commit: 920f0ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
hey-api-docs Ready Ready Preview, Comment Dec 23, 2025 10:32pm

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

❌ Patch coverage is 27.05146% with 1049 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.40%. Comparing base (0c09e6c) to head (3df858f).

Files with missing lines Patch % Lines
...napi-ts/src/plugins/@hey-api/sdk/model/resource.ts 6.70% 334 Missing ⚠️
packages/openapi-ts/src/ts-dsl/utils/context.ts 3.42% 169 Missing ⚠️
...s/openapi-ts/src/plugins/@hey-api/sdk/v1/plugin.ts 2.56% 38 Missing ⚠️
...api-ts/src/plugins/@hey-api/sdk/model/structure.ts 21.05% 30 Missing ⚠️
...api-ts/src/plugins/@angular/common/httpRequests.ts 10.71% 25 Missing ⚠️
packages/openapi-ts/src/ts-dsl/mixins/modifiers.ts 47.91% 25 Missing ⚠️
packages/openapi-ts/src/ts-dsl/decl/func.ts 8.69% 21 Missing ⚠️
packages/openapi-ts/src/ts-dsl/expr/attr.ts 13.04% 20 Missing ⚠️
packages/openapi-ts/src/ts-dsl/utils/name.ts 33.33% 16 Missing ⚠️
packages/openapi-ts/src/ts-dsl/utils/render.ts 83.33% 15 Missing ⚠️
... and 79 more
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3109    +/-   ##
========================================
  Coverage   33.39%   33.40%            
========================================
  Files         429      431     +2     
  Lines       33654    33873   +219     
  Branches     2156     2180    +24     
========================================
+ Hits        11238    11314    +76     
- Misses      22388    22531   +143     
  Partials       28       28            
Flag Coverage Δ
unittests 33.40% <27.05%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 20, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@3109
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@3109

commit: 3df858f

@opswiz
Copy link

opswiz commented Dec 24, 2025

For, #2437 (comment)

Sure @mrlubos Will test the new PR.

Commenting here to keep the conversation here to submit any feedback if applicable

@mrlubos
Copy link
Member Author

mrlubos commented Dec 24, 2025

I'm still polishing but yeah let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect class split logic for SDK when asClass: true Missing methods with nested operation ID's with class SDKs

3 participants