-
-
Notifications
You must be signed in to change notification settings - Fork 284
fix: use serialized body in SSE client requests #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
@bilby91 is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 6505659 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cc699b0 to
393de79
Compare
393de79 to
ad2e7b2
Compare
ad2e7b2 to
6ab9677
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3123 +/- ##
==========================================
- Coverage 33.44% 33.39% -0.06%
==========================================
Files 429 429
Lines 33599 33661 +62
Branches 2156 2156
==========================================
+ Hits 11238 11240 +2
- Misses 22333 22393 +60
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
commit: |
|
@bilby91 hey! Would you be able to add a unit test to capture the behavior? Snapshots are good for capturing generated output, unit tests would be helpful for seeing what it actually does |
|
Yep. I'll take care of this. Thanks for taking the time to review. |
|
Thank YOU for catching these bugs! |
SSE client calls were using raw `opts.body` instead of properly serialized body data, causing SSE requests with JSON bodies to send malformed data. Now correctly passes `serializedBody` (via `getValidRequestBody`) to `createSseClient` across all affected client adapters (fetch, angular, axios, ky, next, nuxt).
6ab9677 to
6505659
Compare
|
@mrlubos Added some tests. I think doing it on client-core should be enough right ? If not, let me know! |
|
Ping @mrlubos |
SSE client calls were using raw
opts.bodyinstead of properly serialized body data, causing SSE requests with JSON bodies to send malformed data. Now correctly passesserializedBody(viagetValidRequestBody) tocreateSseClientacross all affected client adapters (fetch, angular, axios, ky, next, nuxt).