chore: sync from webzHQ monorepo (Cloudflare migration)#3
Merged
Conversation
- Remove landing/vercel.json (now using Cloudflare Pages) - Add landing/_headers for Cloudflare routing - Add Cloudflare Pages deploy workflow - Update configs, docs, and source from monorepo iterations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Review Summary by QodoMigrate from Vercel to Cloudflare Pages deployment
WalkthroughsDescription• Migrate deployment from Vercel to Cloudflare Pages • Add GitHub Actions workflow for automated Cloudflare deployment • Add Cloudflare routing headers configuration • Update husky prepare script for non-git environments Diagramflowchart LR
A["Vercel Config<br/>vercel.json"] -->|Remove| B["Cloudflare Pages"]
C["GitHub Actions"] -->|Add Deploy Workflow| B
D["Routing Headers<br/>_headers"] -->|Add| B
E["Package Scripts<br/>husky prepare"] -->|Update| F["Non-git Safe"]
File Changes1. .github/workflows/deploy.yml
|
Code Review by Qodo
1. Prepare script breaks Windows
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting WalkthroughThis change migrates deployment from Vercel to Cloudflare Pages by adding a GitHub Actions workflow, removing Vercel configuration files, adding a security header, and updating the prepare script to gracefully handle environments without a Git repository. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| "format": "prettier --write \"src/**/*.ts\"", | ||
| "format:check": "prettier --check \"src/**/*.ts\"", | ||
| "prepare": "husky install" | ||
| "prepare": "[ -d .git ] && husky install || true" |
There was a problem hiding this comment.
1. Prepare script breaks windows 🐞 Bug ⛯ Reliability
The updated prepare script uses POSIX shell syntax ([ -d .git ] and true) which will fail in Windows’ default npm shell (cmd/powershell), potentially breaking npm install for Windows contributors.
Agent Prompt
### Issue description
`package.json` uses a POSIX-shell `prepare` script. This can fail on Windows’ default npm shell, breaking `npm install` for contributors.
### Issue Context
The repo uses husky hooks, and `prepare` is used to install them. The new script relies on `[ -d .git ]` and `true`, which are not portable across npm shells.
### Fix Focus Areas
- package.json[43-57]
- .husky/pre-commit[1-2]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
webzHQmonorepo back to this standalone repolanding/vercel.json)landing/_headersfor Cloudflare routingContext
This repo was copied into the
TheFreeBatteryFactory/webzHQmonorepo where further development happened. These changes are being synced back as part of extracting apps from the monorepo into standalone repos. Monorepo is source-of-truth for conflicts.Test plan
landing/directory contains index.html, script.js, style.csssunsetter-aqm.batterypack.devserves correctlySummary by CodeRabbit