feat: convert project to es module#541
Closed
hereje wants to merge 6 commits into
Closed
Conversation
- convert type to module on package.json - replace optimist with yargs-parser - update references to optimist on test files - fix broken files - update import for json files - set required minimal node engine - update .nvmrc file
Member
|
Hi @hereje, many thanks for this! However, first we would like to review and merge #536 (which very likely will take a few days/weeks) ... before tackling #518. Hence I think it is better to either wait or to base this PR on #536. I would rather vote to wait until we have integrated / tested #536. cc @kili-ilo |
- convert type to module on package.json - replace optimist with yargs-parser - update references to optimist on test files - fix broken files - update import for json files - set required minimal node engine - update .nvmrc file
- replace 'assert' with 'with'
Member
|
Closed due to inactivity. Please re-open if you want to give it another go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert project to ESM
Fixes: #518