Skip to content

update nix section with newly added module and pkg - #172

Draft
tree-sapii wants to merge 1 commit into
hgaiser:mainfrom
tree-sapii:push-wrunysmuyksp
Draft

update nix section with newly added module and pkg#172
tree-sapii wants to merge 1 commit into
hgaiser:mainfrom
tree-sapii:push-wrunysmuyksp

Conversation

@tree-sapii

Copy link
Copy Markdown

NixOS/nixpkgs#544596 got merged into nixpkgs last month with the the pkg already existing in unstable PR tracker.
There is also a module init pr NixOS/nixpkgs#544393, however its still not merged. I will open this as draft until that is merged.

I wonder if its best to leave the existing instructions on how to use this project's consumable module or to delete them and the module file.

@hgaiser

hgaiser commented Aug 13, 2026

Copy link
Copy Markdown
Owner

I'm not that familiar with the NixOS ecosystem. My philosophy regarding moonshine is generally, if there is a preferred approach, let's not clutter things with other approaches.

Am I correct that if NixOS/nixpkgs#544393 is merged, you can add moonshine to the list of installed packages in your config and that's it? Is there still a reason to host nix files in this repository if that gets merged?

@repparw

repparw commented Aug 17, 2026

Copy link
Copy Markdown

package's already merged from another pr, that pr remains with the module implementation.

ideally you could keep the flake for dev and qa of the package (in nix you can use this repo as an input, that's what the current setup does to use the repo defined module and package)

you could drop the module from the repo though when/if it gets merged, as you can just override the module's package option for testing the flake one, without replacing the canonical module implementation from nixpkgs

if it's going to be 'blessed' by you upstream, you might want to say that there (they might add you as maintainer for the package, so eg you can approve updates when you make a release if another maintainer doesn't see it before you)

@tree-sapii

Copy link
Copy Markdown
Author

You could also copy nixpkgs's module in here for the dev module to not have inconsistencies with what most users are going to use

@repparw

repparw commented Aug 18, 2026

Copy link
Copy Markdown

sure, once it lands it could be easier to keep both things. i would wait until it gets approval as it seems to have a couple things that still need ironing out compared to the shipped one here

@tree-sapii

Copy link
Copy Markdown
Author

NixOS/nixpkgs#544393 merged, will update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants