update nix section with newly added module and pkg - #172
Conversation
27df960 to
e32653d
Compare
|
I'm not that familiar with the NixOS ecosystem. My philosophy regarding moonshine is generally, if there is a preferred approach, let's not clutter things with other approaches. Am I correct that if NixOS/nixpkgs#544393 is merged, you can add |
|
package's already merged from another pr, that pr remains with the module implementation. ideally you could keep the flake for dev and qa of the package (in nix you can use this repo as an input, that's what the current setup does to use the repo defined module and package) you could drop the module from the repo though when/if it gets merged, as you can just override the module's package option for testing the flake one, without replacing the canonical module implementation from nixpkgs if it's going to be 'blessed' by you upstream, you might want to say that there (they might add you as maintainer for the package, so eg you can approve updates when you make a release if another maintainer doesn't see it before you) |
|
You could also copy nixpkgs's module in here for the dev module to not have inconsistencies with what most users are going to use |
|
sure, once it lands it could be easier to keep both things. i would wait until it gets approval as it seems to have a couple things that still need ironing out compared to the shipped one here |
|
NixOS/nixpkgs#544393 merged, will update soon. |
NixOS/nixpkgs#544596 got merged into nixpkgs last month with the the pkg already existing in unstable PR tracker.
There is also a module init pr NixOS/nixpkgs#544393, however its still not merged. I will open this as draft until that is merged.
I wonder if its best to leave the existing instructions on how to use this project's consumable module or to delete them and the module file.