Skip to content

fix: reject resume requests for stale sessions #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brongan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject resume requests for stale sessions #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions moonshine-core/src/session/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,15 +452,21 @@ impl SessionManager {
pub(crate) async fn update_keys(&self, keys: SessionKeyData) -> Result<(), ()> {
let guard = self.inner.lock().await;

if guard.session.is_none() {
tracing::warn!("No active session to update keys for.");
if guard.stop.is_shutdown_triggered() {
tracing::warn!("Session is shutting down; rejecting resume key update.");
return Err(());
}

if !matches!(guard.session.as_ref(), Some(SessionState::Active(_))) {
tracing::warn!("No active streaming session to update keys for.");
return Err(());
}

if let Some(keys_tx) = &guard.keys_tx {
keys_tx.send_replace(keys);
} else {
tracing::warn!("No active session to update keys for.");
tracing::warn!("Active streaming session has no key sender; rejecting resume.");
return Err(());
}

Ok(())
Expand Down