You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First off, by default, gocloc prevents the same content files (checked by md5 checksum) from being counted multiple times. The original purpose of providing the --skip-duplicated option is to skip this duplication check and count even the duplicated ones.
Considering the above, I think the option name --skip-duplicated does not reflect the intended behavior.
Instead of merging this change, I think it would be better to change the option name. For instance, how about changing it to --include-duplicates?
Hi there! I just came across this as well and was confused because I expected skip-duplicated to not include duplicated files in the output.
Which direction is this going to go? Renaming the flag, or changing the code behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default operations in
goclocwill consider the same files as only one file, which will leads to confusion.And I find the flag is wrong.