fix: giallozafferano ingredients #1981
Conversation
|
@jknndy Totally get why this implementation would be used in favor of the previous one I had opened. There were two things I noticed in the code though that give me slight pause. First, the units is a discrete list and would potentially break if another unit were used for some reason such as |
|
@jknndy Hi there 👋 Just circling back here to see if there were any thoughts about the comments? I'll probably be throwing up some more PRs here this week for other sites I've run into just to continue to help provide support but I wanted to make sure this was closed out first so it can be an example for anyone if they run into this same situation moving forward. |
See #1980 for discussion
@michaelplatt07 , let me know what you think of this implementation